Skip to content

DFS and BFS search algorithms - Resolve #4229#4230

Merged
siriak merged 6 commits into
TheAlgorithms:masterfrom
snirt:master
Aug 13, 2023
Merged

DFS and BFS search algorithms - Resolve #4229#4230
siriak merged 6 commits into
TheAlgorithms:masterfrom
snirt:master

Conversation

@snirt
Copy link
Copy Markdown
Contributor

@snirt snirt commented Jul 6, 2023

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

Resolve #4229

debasishbsws
debasishbsws reviewed Jul 7, 2023
View reviewed changes
Comment thread pom.xml Outdated
debasishbsws
debasishbsws reviewed Jul 7, 2023
View reviewed changes
Comment thread src/main/java/com/thealgorithms/datastructures/Node.java
debasishbsws
debasishbsws requested changes Jul 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@debasishbsws debasishbsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also Check the linting error

@snirt
Copy link
Copy Markdown
Contributor Author

snirt commented Jul 10, 2023

Regarding the linter format, I suggest to configure it to allow the left-side format in the attached image:
Screenshot from 2023-07-10 13-32-18
This format helps with readability

@snirt snirt requested a review from debasishbsws July 10, 2023 13:54
@siriak
Copy link
Copy Markdown
Member

siriak commented Jul 10, 2023

Regarding the linter format, I suggest to configure it to allow the left-side format in the attached image: Screenshot from 2023-07-10 13-32-18 This format helps with readability

I agree with you, could you do it here or in a separate PR if it involves a lot of changes?

@snirt snirt mentioned this pull request Jul 11, 2023
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 13, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Aug 13, 2023
siriak
siriak approved these changes Aug 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) August 13, 2023 06:21
@siriak siriak requested a review from albina-astr as a code owner August 13, 2023 06:22
@siriak
Copy link
Copy Markdown
Member

siriak commented Aug 13, 2023

@debasishbsws could you review again?

debasishbsws
debasishbsws approved these changes Aug 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@debasishbsws debasishbsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@siriak siriak merged commit 1884857 into TheAlgorithms:master Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siriak siriak siriak approved these changes

@debasishbsws debasishbsws debasishbsws approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@albina-astr albina-astr Awaiting requested review from albina-astr

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] DFS and BFS search algorithms are lack of effective tests and Node class should be decoupled from DFS

3 participants

@snirt @siriak @debasishbsws