chore: ignore SIGINT inside driver process#23028
Merged
Merged
Conversation
yury-s
reviewed
May 16, 2023
ac2bc2b to
aece2d8
Compare
aece2d8 to
9e2721d
Compare
yury-s
approved these changes
May 16, 2023
This was referenced May 18, 2023
mxschmitt
added a commit
that referenced
this pull request
May 18, 2023
Issue is that [when `stop()` is called](https://github.com/microsoft/playwright/blob/28504f6dc7ffbd920244365c6f890410f1a5d9a1/tests/library/browsertype-launch-selenium.spec.ts#L202), `onExit()` gets called and then it throws an unhandled rejection. This regressed in #23028. I didn't find a reason to keep onExit, so removed it for now since transport should handle these scenarios. Fixes #23110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsoft/playwright-python#1843
Almost reverts #11826 since this is not used by VSCode anymore and was legacy.