buffer: fix atob input validation
#42539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
reviewed
Mar 31, 2022
Co-authored-by: Michaël Zasso <[email protected]>
targos
approved these changes
Mar 31, 2022
This comment was marked as outdated.
This comment was marked as outdated.
Trott
approved these changes
Mar 31, 2022
Mesteery
approved these changes
Apr 1, 2022
marsonya
approved these changes
Apr 2, 2022
|
Landed in bba82cd |
juanarbol
added a commit
to juanarbol/node
that referenced
this issue
Apr 5, 2022
Fixes: nodejs#42530 PR-URL: nodejs#42539 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
Closed
Merged
juanarbol
added a commit
that referenced
this issue
Apr 6, 2022
Fixes: #42530 PR-URL: #42539 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I've added a test case, as it looks like WTP do not test for input with whitespace: https://github.com/web-platform-tests/wpt/blob/HEAD/html/webappapis/atob/base64.any.js
//cc @jasnell
Fixes: #42530