Skip to content

Issue/2963 - Refactoring and added 12 Junit tests#2964

Merged
siriak merged 10 commits into
TheAlgorithms:masterfrom
DD2480group1:issue/2963
Mar 10, 2022
Merged

Issue/2963 - Refactoring and added 12 Junit tests#2964
siriak merged 10 commits into
TheAlgorithms:masterfrom
DD2480group1:issue/2963

Conversation

@leren1

@leren1 leren1 commented Feb 24, 2022

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Refactoring
  • Added 12 Junit tests

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@leren1 leren1 changed the title Issue/2963 Issue/2963 - Refactoring and added 12 Junit tests Feb 24, 2022
siriak
siriak reviewed Mar 8, 2022
View reviewed changes
Comment thread src/main/java/com/thealgorithms/maths/Gaussian.java Outdated
siriak
siriak requested changes Mar 8, 2022
View reviewed changes

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the comments and update to the latest master, I see that some of your changes have already been merged

Comment thread src/main/java/com/thealgorithms/maths/FFT.java Outdated
Comment thread src/main/java/com/thealgorithms/maths/Gaussian.java
Comment thread src/test/java/com/thealgorithms/maths/FFTTest.java Outdated
@leren1

leren1 commented Mar 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Please resolve the comments and update to the latest master, I see that some of your changes have already been merged

check now :), is it done?

siriak
siriak approved these changes Mar 10, 2022
View reviewed changes

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@siriak siriak merged commit 49a4a83 into TheAlgorithms:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leren1 @siriak