perf(cdk/clipboard): do not run change detection if there are no cdkCopyToClipboardCopied listeners#24204
Closed
arturovt wants to merge 1 commit into
Closed
perf(cdk/clipboard): do not run change detection if there are no cdkCopyToClipboardCopied listeners#24204arturovt wants to merge 1 commit into
cdkCopyToClipboardCopied listeners#24204arturovt wants to merge 1 commit into
Conversation
…CopyToClipboardCopied` listeners
crisbeto
reviewed
Jan 13, 2022
crisbeto
left a comment
Member
There was a problem hiding this comment.
I'm not sure that the one less change detection is worth the extra code we have to ship.
Member
|
We talked about this within the team and we decided that all the extra code isn't enough to justify an extra change detection so far down in the component tree. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does have breaking change.