Vigenere #5868
Closed
Vigenere #5868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desc: code ask user to leave key blank to generate a random key.
A random key with a length as long as the sent message is
now able to be generated at the users request. The random
key is printed after the encrypted message is printed.
Desc: Funciton documentation written. Documented key print during encryption conditional. Ran black on script.
Desc: the variable translated is now initialized outside the conditional
block where it is first used. Clearing the unbound error.
changed randomKey generator list comprehension code to the basic for loop with enumerate.
Function created that creates a random letter key, based off the length of the message to be encrypted. Added option for user to use the random key function. Added printing of the random key after the printing of the encrypted message.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
tianyizheng02
requested changes
Jul 31, 2023
Contributor
tianyizheng02
left a comment
There was a problem hiding this comment.
Please update your fork's main branch and rebase this branch so that this PR is up to date. This file has changed significantly since this PR was made.
| "\nEnter key [alphanumeric], " | ||
| "leave blank for a random key as long as the message." | ||
| ) | ||
| key = str(input("Enter the Key: ").strip()) |
Contributor
There was a problem hiding this comment.
Suggested change
| key = str(input("Enter the Key: ").strip()) | |
| key = input("Enter the Key: ").strip() |
The str call is unnecessary because input and strip already return strings
Comment on lines
+15
to
+18
| randomKey = False | ||
| if not len(key): | ||
| randomKey = True | ||
| key = generateRandomKey(message) |
Contributor
There was a problem hiding this comment.
Suggested change
| randomKey = False | |
| if not len(key): | |
| randomKey = True | |
| key = generateRandomKey(message) | |
| randomKey = len(key) == 0 | |
| key = generateRandomKey(message) if randomKey else key |
| print("Message key:\n%s" % key.lower()) | ||
|
|
||
|
|
||
| def generateRandomKey(message: str) -> str: |
Contributor
There was a problem hiding this comment.
- All functions and variable names follow Python naming conventions.
This means snake case: generate_random_key
Comment on lines
+53
to
+60
| message = message.strip() | ||
| randomKey = [] | ||
|
|
||
| for i, letter in enumerate(message): | ||
| secret_letter = secrets.choice(LETTERS) | ||
| randomKey.append(secret_letter) | ||
|
|
||
| return "".join(randomKey) |
Contributor
There was a problem hiding this comment.
Suggested change
| message = message.strip() | |
| randomKey = [] | |
| for i, letter in enumerate(message): | |
| secret_letter = secrets.choice(LETTERS) | |
| randomKey.append(secret_letter) | |
| return "".join(randomKey) | |
| random_key = [secrets.choice(LETTERS) for _ in message.strip()] | |
| return "".join(random_key) |
Contributor
|
Closing this PR due to inactivity. Hacktoberfest is drawing near, so we're going to start clearing out inactive PRs from the backlog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Function created that generate a random letter key, based off the length of the message to be encrypted.
Added option for user to use the random key function.
Added printing of the random key after the printing of the encrypted message.
Moved initialization of translated variable outside of conditional block to prevent an
unbound error.
Encryption of a message using this function should not be considered secure.
Still new to git and github. I read the contribute guide and did what I could. Since this generates a random key every time, using doc tests, or unittest may not work. I tested this with many different iterations of: all work and no play make jack a dull boy
in the following manner:
spaces and no spaces
leading, trailing, leading and trailing white space
all lowercase, all uppercase, mixed upper/lower case
algorithm work as far a I can tell.
Ran black, flake8 and pre-commit on the script.
Thanks for opportunity to contribute. Cheers.
Checklist:
Fixes: #{$ISSUE_NO}.