Changed filename, added non-preemptive SJF#5849
Changed filename, added non-preemptive SJF#5849sangin-lee wants to merge 5 commits intoTheAlgorithms:masterfrom sangin-lee:shortestjob
Conversation
…first.py], added non-preemptive SJF on [shortest_job_first.py]
ghost
left a comment
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ghost
left a comment
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
@cclauss @dhruvmanila Could you please review my work? |
|
Fixed doctest results |
|
As a user, I would find it very distracting to see |
Would it be better to modify codes to print out only first digit of the decimal point? or maybe two digits? |
|
5.12345 is OK if there are actual values there to the right of the decimal point but 5.00000 must be shortened to 5.0 |
|
Fixed formatting. Thanks for commenting!! |
|
@cclauss What should I do to merge this PR? |
|
@cclauss can you follow it? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Describe your change:
Changed filename of previous [shortest_job_fisrt.py] to [shortest_remaining_time_first.py] because it comes under to
URL : https://en.wikipedia.org/wiki/Shortest_remaining_time
Added new [shortest_job_first.py] which is non-preemptive shortest job first. It comes under to
URL : https://en.wikipedia.org/wiki/Shortest_job_next
+Added Wikipedia URL in each comments
Checklist:
Fixes: #{$ISSUE_NO}.