Skip to content

Clarify public and private wiki permission levels#10237

Merged
lecoursen merged 5 commits intogithub:mainfrom
HonkingGoose:docs/10075
Oct 6, 2021
Merged

Clarify public and private wiki permission levels#10237
lecoursen merged 5 commits intogithub:mainfrom
HonkingGoose:docs/10075

Conversation

@HonkingGoose
Copy link
Copy Markdown
Contributor

Why:

Closes #10075

What's being changed:

  • Change the current line to "Edit wikis in public repos"
  • Add a second entry for "Edit wikis in private repos" that only has Xs in write, maintain and admin.

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Question: Do we need another {% ifversion fpt %} on the private wiki line???

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 22, 2021
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Sep 23, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

@HonkingGoose
Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link
Copy Markdown
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HonkingGoose! I'm going to apply one small suggestion and then merge. ⚡

@lecoursen lecoursen added the ready to merge This pull request is ready to merge label Oct 5, 2021
@lecoursen lecoursen enabled auto-merge October 5, 2021 18:52
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Oct 5, 2021
@HonkingGoose HonkingGoose requested a review from lecoursen October 6, 2021 07:30
@lecoursen lecoursen merged commit 2830c75 into github:main Oct 6, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 6, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[From Zendesk] Wiki in private repo can't be edited by users with Read or Triage access

4 participants