Skip to content

/ components

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(material/theming): normalize config in all typography mixins for non-mdc components #21937

Merged
merged 1 commit into from Feb 24, 2021
Merged

refactor(material/theming): normalize config in all typography mixins for non-mdc components #21937

merged 1 commit into from Feb 24, 2021
+144 −92

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Feb 17, 2021

This is split off of #21778 which covers MDC conmponents as well
@mmalerba mmalerba requested review from andrewseguin, crisbeto, devversion, jelbourn and angular/dev-infra-components as code owners Feb 17, 2021
@google-cla google-cla bot added the cla: yes label Feb 17, 2021
@crisbeto
crisbeto approved these changes Feb 18, 2021
View changes
Copy link
Member

@crisbeto crisbeto left a comment

LGTM, but the CI is failing.
@mmalerba mmalerba force-pushed the mmalerba:typog-norm-non-mdc branch 2 times, most recently from f99b9ee to bf207b1 Feb 18, 2021
@mmalerba mmalerba added the target: patch label Feb 18, 2021
@jelbourn
jelbourn approved these changes Feb 18, 2021
View changes
Copy link
Member

@jelbourn jelbourn left a comment

LGTM
@jelbourn jelbourn added the merge ready label Feb 18, 2021
@andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Feb 23, 2021

Needs rebase
@mmalerba mmalerba force-pushed the mmalerba:typog-norm-non-mdc branch from bf207b1 to 0cef8b0 Feb 24, 2021
@mmalerba
refactor(material/theming): normalize config in all typography mixins
Loading status checks…
a8b2cef 
for non-mdc components

This is split off of #21778 which covers MDC conmponents as well
@mmalerba mmalerba force-pushed the mmalerba:typog-norm-non-mdc branch from 0cef8b0 to a8b2cef Feb 24, 2021
@mmalerba
Copy link
Contributor Author

@mmalerba mmalerba commented Feb 24, 2021

@andrewseguin rebased
@andrewseguin andrewseguin added target: minor and removed target: patch labels Feb 24, 2021
@andrewseguin andrewseguin merged commit c34511e into angular:master Feb 24, 2021
16 checks passed
16 checks passed
Inclusive Language Check completed with success
Details
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: upload_release_packages Your tests passed on CircleCI!
Details
ci/circleci: view_engine_build Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelbourn jelbourn

@crisbeto crisbeto

@andrewseguin andrewseguin

@devversion devversion

@angular/dev-infra-components dev-infra-components

Assignees
No one assigned
Labels
cla: yes merge ready target: minor
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@mmalerba @andrewseguin @jelbourn @crisbeto