C#: Relational patterns#4789
Merged
tamasvajk merged 4 commits intoJan 19, 2021
Merged
Conversation
2229e09 to
c6a1cbc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0daa959 to
7e77673
Compare
2d4257a to
8400a38
Compare
Contributor
Author
|
@hvitved I think this is ready to be merged. There's a slight performance loss on |
hvitved
approved these changes
Jan 19, 2021
Contributor
That is within the margin of error, so I don't think there is an actual slowdown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relational patterns were at one point merged before. Then reverted, and now this is the revert of the revert commit 998e2de.
Stats jobRebased on top of #4656
Still missing:
https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/767/https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/781/