Skip to content

/ Java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #1709 Longest palindromic subsequence #1713

Merged
merged 4 commits into from Oct 14, 2020
Merged

Fixes: #1709 Longest palindromic subsequence #1713

merged 4 commits into from Oct 14, 2020

Conversation

@matteomessmer
Copy link
Contributor

@matteomessmer matteomessmer commented Oct 9, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

I added the Longest Palindromic Subsequence algorithm

References

Issue #1709

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@matteomessmer
LPS algorithm
1bf0fe0
@matteomessmer
LPS algorithm fix
196fcb3
@matteomessmer
Fixes: #1709
9bcb7f5
@rbshealy
rbshealy requested changes Oct 9, 2020
View changes
DynamicProgramming/LongestPalindromicSubsequence.java Outdated Show resolved Hide resolved
DynamicProgramming/LongestPalindromicSubsequence.java Outdated Show resolved Hide resolved
DynamicProgramming/LongestPalindromicSubsequence.java Outdated Show resolved Hide resolved
DynamicProgramming/LongestPalindromicSubsequence.java Outdated Show resolved Hide resolved
DynamicProgramming/LongestPalindromicSubsequence.java Show resolved Hide resolved
@matteomessmer
added tests
60c0291
@matteomessmer
Copy link
Contributor Author

@matteomessmer matteomessmer commented Oct 14, 2020

So, is it ok now?
@rbshealy
rbshealy approved these changes Oct 14, 2020
View changes
@rbshealy
Copy link
Contributor

@rbshealy rbshealy commented Oct 14, 2020

lgtm - great work!
@rbshealy rbshealy merged commit a19d8b2 into TheAlgorithms:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbshealy rbshealy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@matteomessmer @rbshealy
You can’t perform that action at this time.