Skip to content
master
Go to file
Code

Latest commit

… implicit void return

Summary:
In D21814721 (d7711aa) I added support for basing whether a function implicitly returns void on whether an exhaustive check on a Flow Enum was successful.

In this diff, I add support for unions. More specifically, when the switch discriminant (what we're switching on) is refineable (an identifier or property), then each `case` refines the value of the discriminant. If we return from each case, and the switch does not have a `default`, we can check whether the type of the discriminant after the switch is empty. If it is, then we don't add the implicit void to the function return. This works because `EmptyT` < `FunImplicitVoidReturnT` will succeed without the additional flows `FunImplicitVoidReturnT` triggers (flowing void to the return type).

Currently, people have to add a `default` case and throw from it, or use other similar patterns.

E.g. the following is now allowed:
```
function f(x: 'a' | 'b'): number {
  switch (x) {
    case 'a':
      return 1;
    case 'b':
      return 2;
  }
}
```

Reviewed By: samwgoldman

Differential Revision: D23202941

fbshipit-source-id: 3494c66d5898630f93c8ae3ae7827ddf2aa1ec5c
96868b5

Files

Permalink
Failed to load latest commit information.
Type
Name
Latest commit message
Commit time
Sep 2, 2020
Sep 2, 2020
Jul 17, 2020
Sep 2, 2020

README.md

Flow

CircleCI Follow @flowtype GitHub GitHub contributors GitHub top language Join Discord Chat

Flow is a static typechecker for JavaScript. To find out more about Flow, check out flow.org.

For a background on the project, please read this overview.

Contents

Requirements

Flow works with:

  • macOS
  • Linux (64-bit)
  • Windows (64-bit, Windows 10 recommended)

There are binary distributions for each of these platforms and you can also build it from source on any of them as well.

Using Flow

Check out the installation instructions, and then how to get started.

Using Flow's parser from JavaScript

While Flow is written in OCaml, its parser is available as a compiled-to-JavaScript module published to npm, named flow-parser. Most end users of Flow will not need to use this parser directly, but JavaScript packages which make use of parsing Flow-typed JavaScript can use this to generate Flow's syntax tree with annotated types attached.

Building Flow from source

Flow is written in OCaml (OCaml 4.07.1 is required).

  1. Install opam:
  1. Validate the opam version is 2.x.x:
opam --version

The following instructions expect 2.x.x. Should your package manager have installed a 1.x.x version, please refer to the opam docs to install a newer version manually.

  1. Initialize opam:
opam init
  1. Install OCaml and Flow's dependencies:
# from within this git checkout
opam switch create . --deps-only -y
  1. Build the flow binary:
eval $(opam env)
make

This produces the bin/flow binary.

  1. Build flow.js (optional):
opam install -y js_of_ocaml.3.4.0
make js

This produces bin/flow.js.

The Flow parser can also be compiled to JavaScript. Read how here.

Running the tests

To run the tests, first compile flow using make. Then run bash ./runtests.sh bin/flow

There is a make test target that compiles and runs tests.

To run a subset of the tests you can pass a second argument to the runtests.sh file.

For example: bash runtests.sh bin/flow class | grep -v 'SKIP'

Join the Flow community

License

Flow is MIT-licensed (LICENSE). The website and documentation are licensed under the Creative Commons Attribution 4.0 license (website/LICENSE-DOCUMENTATION).

You can’t perform that action at this time.