Skip to content

fix(material-experimental/mdc-menu/testing): add unimplemented methods#20352

Merged
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:mdc-menu-implementation
Aug 20, 2020
Merged

fix(material-experimental/mdc-menu/testing): add unimplemented methods#20352
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:mdc-menu-implementation

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented Aug 18, 2020

Adds the logic for the methods that weren't implemented for the MDC-based menu harness.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Aug 18, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 18, 2020
@crisbeto
fix(material-experimental/mdc-menu/testing): add unimplemented methods
c66045c 
Adds the logic for the methods that weren't implemented for the MDC-based menu harness.
@crisbeto crisbeto force-pushed the mdc-menu-implementation branch from 3eef469 to c66045c Compare August 18, 2020 15:04
mmalerba
mmalerba approved these changes Aug 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 18, 2020
@wagnermaciel wagnermaciel merged commit e784f8f into angular:master Aug 20, 2020
wagnermaciel pushed a commit that referenced this pull request Aug 20, 2020
@crisbeto @wagnermaciel
fix(material-experimental/mdc-menu/testing): add unimplemented methods (
0178813 
#20352)

Adds the logic for the methods that weren't implemented for the MDC-based menu harness.

(cherry picked from commit e784f8f)
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 20, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mmalerba mmalerba mmalerba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @mmalerba @googlebot @wagnermaciel