Skip to content

feat(material/tree): add test harness for MatTree#20323

Merged
annieyw merged 4 commits into
angular:masterfrom
annieyw:mat-tree-harness
Sep 23, 2020
Merged

feat(material/tree): add test harness for MatTree#20323
annieyw merged 4 commits into
angular:masterfrom
annieyw:mat-tree-harness

Conversation

@annieyw
Copy link
Copy Markdown
Contributor

@annieyw annieyw commented Aug 14, 2020

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 14, 2020
@annieyw annieyw force-pushed the mat-tree-harness branch 2 times, most recently from e62e777 to 9c689b7 Compare August 18, 2020 22:38
@annieyw annieyw marked this pull request as ready for review August 18, 2020 22:38
@annieyw annieyw requested a review from a team August 18, 2020 22:38
@annieyw
Copy link
Copy Markdown
Contributor Author

annieyw commented Aug 18, 2020

patched #20226 and #20145
commits start from "tree harness basic implementation ..."

Copy link
Copy Markdown
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - marking as blocked until the pre-req PRs go through

@mmalerba mmalerba added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Aug 18, 2020
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Sep 14, 2020
@annieyw annieyw merged commit 5916800 into angular:master Sep 23, 2020
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Sep 24, 2020
* tree harness basic implementation - flat tree nodes throw error for getChildren/getDescendants

* only implement getNodes for tree for now

* fix imports and add entrypoint to config.bzl

* clean up duplicate host:{} and @HostBinding
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 24, 2020
@annieyw annieyw deleted the mat-tree-harness branch November 9, 2020 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants