refactor(@angular/cli): replace experimental workspace API with stable API#18535
Merged
Conversation
d7e7f97 to
7c3a775
Compare
…e API This change removes one of the last usages of the experimental workspace API.
7c3a775 to
6a1fedd
Compare
alan-agius4
reviewed
Aug 17, 2020
| // Remove BOM | ||
| start = 3; | ||
| } | ||
| const content = data.toString('utf-8', start); |
Collaborator
There was a problem hiding this comment.
Maybe data.toString('utf-8').replace(/^\uFEFF/, '') to remove the BOM?
Member
Author
There was a problem hiding this comment.
Less efficient especially for large files due to the need to allocate two strings plus the regex cost.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes one of the last usages of the experimental workspace API.